191 scenario#2 #780
Merged
191 scenario#2 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
approved these changes
Jan 20, 2022
| @@ -104,7 +104,7 @@ export class ApplicationsComponent extends CabinetDataComponent implements OnIni | |||
| * @param Application event | |||
| */ | |||
| onReject(application: Application): void { | |||
| const applicationUpdate = new ApplicationUpdate(application.id, this.applicationStatus.Rejected); | |||
| const applicationUpdate = new ApplicationUpdate(application.id, this.applicationStatus.Rejected, application?.rejectionMessage ); | |||
There was a problem hiding this comment.
I saw same changes in another pr. be ready for conflicts
perepichai
added a commit
that referenced
this pull request
Jan 21, 2022
* feat: add reject modal window component * feat: add reject reason field * feat: add textarea to reject modal component * feat: update onReject method * feat: update element styles * feat: add rejection message property * feat: display rejection message * feat: add third argument to onReject method * feat: update onReject method * feat: small component updates * feat: fixing test * feat: add types to arguments * feat: remove onReject method * feat: update declaration section * feat: update indentations * feat: test experiment * feat: test experiment * feat: test experiment * fix: `Не вказано` is removed * fix: add red border class if textarea is empty * fix: update test * fix: update test * fix: update test final * fix: remove wrapper and update disabled state * fix: remove line * feat: disable button where necessary * fix: code improvements * feat: replace formgroup with formcontrol * fix: remove formcontrolname * feat: hide instead of disable * 191 scenario#2 (#780) * feat: add props for popup when approve or reject * feat: display popup when confirm application Co-authored-by: Dmitry <dmitryy90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the task: ita-social-projects/OoS-Backend#191
Is implemented from scenario#2: "AND approval pop-up appears".