Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if workshop deleted #874

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Error if workshop deleted #874

merged 5 commits into from
Feb 18, 2022

Conversation

kokole110
Copy link
Contributor

Issue: #855

this.router.navigate([this.previousUrl]);
} else {
this.location.back();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume false must be returned in else block for cancelling flow

@kokole110 kokole110 force-pushed the fix/errorIfWorkshopDeleted branch 2 times, most recently from 6bc76e3 to 2d6e745 Compare February 4, 2022 09:34
@kokole110 kokole110 requested a review from dmitryy90 February 4, 2022 09:44
@kokole110 kokole110 force-pushed the fix/errorIfWorkshopDeleted branch 2 times, most recently from 7f3e908 to 01d136d Compare February 8, 2022 09:24
@kokole110 kokole110 force-pushed the fix/errorIfWorkshopDeleted branch from 01d136d to 569c684 Compare February 18, 2022 10:55
@kokole110 kokole110 force-pushed the fix/errorIfWorkshopDeleted branch from 569c684 to 3f6cb3f Compare February 18, 2022 11:36
@kokole110 kokole110 merged commit 822d1de into develop Feb 18, 2022
@kokole110 kokole110 deleted the fix/errorIfWorkshopDeleted branch February 18, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants