Add Resource Completion Status Update Endpoint for Cooperations #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luiqor
added
documentation
luiqor
commented
Nov 27, 2024
| @@ -69,17 +71,8 @@ const cooperationService = { | |||
| throw createError(409, VALIDATION_ERROR('You can change only either the status or the price in one operation')) | |||
| } | |||
|
|
|||
| const cooperation = await Cooperation.findById(id).exec() | |||
| if (!cooperation) { | |||
There was a problem hiding this comment.
Removed this check because we already have middleware for patch coopeation/{id} endpoint that performs the same validation, but returns a 400 error instead:
{
"status": 400,
"code": "INVALID_ID",
"message": "ID is invalid."
}
3 tasks
luiqor
requested review from
ShadowOfTheSpace,
sandrvvu,
Mike-Popovych and
RomanRozbytskyi
ShadowOfTheSpace
approved these changes
Nov 29, 2024
…source already found
|
sandrvvu
approved these changes
Dec 2, 2024
nebby2105
approved these changes
Dec 3, 2024
luiqor
deleted the
feature/958/endpoint-for-cooperation-resource-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Resource Completion Status Update Endpoint for student to be able to mark cooperation as 'completed' or 'active'
PR where
completionStatusfield was added to model: #966API Endpoint
PATCH /cooperations/{id}/{resourceId}/completionStatusChanges
Previews
Successful update:
bandicam.2024-11-27.19-09-35-038.mp4
Not valid
completionStatuserror preview:An clear error message indicating that this action is restricted to the student role: