Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to initiate the cooperation closing process #1026

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add logic to initiate the cooperation closing process #1026

merged 3 commits into from
Dec 4, 2024

Conversation

ShadowOfTheSpace
Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace commented Dec 4, 2024 •
edited
Loading

  • Added the status request to close to the COOPERATION_STATUS_ENUM and NOTIFICATION_TYPE_ENUM enums
  • Added correct logic to change the needAction

Scenario where Student initiates cooperation closure:

  • Cooperation before Student request
    image_2024-12-04_11-37-56

  • Request from Student to close cooperation
    image_2024-12-04_11-39-41

  • Cooperation after Student request (needAction changed to tutor)
    image_2024-12-04_11-40-01

Scenario where Tutor initiates cooperation closure:

  • Cooperation before Tutor request
    image_2024-12-04_11-41-07

  • Request from Tutor close cooperation
    image_2024-12-04_11-42-06

  • Cooperation after Tutor request (needAction changed to student)
    image_2024-12-04_11-42-27

@ShadowOfTheSpace ShadowOfTheSpace self-assigned this Dec 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShadowOfTheSpace ShadowOfTheSpace linked an issue Dec 4, 2024 that may be closed by this pull request
(SP: 1) Add logic to initiate the cooperation closing process #1019
Closed
2 tasks
@RomanRozbytskyi RomanRozbytskyi self-requested a review December 4, 2024 15:09
@ShadowOfTheSpace ShadowOfTheSpace merged commit f73d300 into develop Dec 4, 2024
4 checks passed
@ShadowOfTheSpace ShadowOfTheSpace deleted the feature/1019/initiate-cooperation-closing-process branch December 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanRozbytskyi RomanRozbytskyi RomanRozbytskyi approved these changes

@nebby2105 nebby2105 nebby2105 approved these changes

@luiqor luiqor luiqor approved these changes

@amoutens amoutens amoutens approved these changes

@dudchakk dudchakk Awaiting requested review from dudchakk

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

@Mike-Popovych Mike-Popovych Awaiting requested review from Mike-Popovych

Assignees

@ShadowOfTheSpace ShadowOfTheSpace

Labels
Backend enhancement New feature or request priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 1) Add logic to initiate the cooperation closing process
5 participants
@ShadowOfTheSpace @amoutens @luiqor @nebby2105 @RomanRozbytskyi