Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced variables #1064

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Replaced variables #1064

wants to merge 2 commits into from
+43 −43

Conversation

ArtemHolikov
Copy link
Contributor

Replace ref => $ref and components => definitions in files:

  • attachment-schema.yaml
  • chat-schema.yaml and chat.yaml
  • course-schema.yaml
  • finished-quiz.yaml
  • lesson-schema.yaml
  • message-schema.yaml
  • note-schema.yaml
  • offer-schema.yaml
  • question-schema.yaml
  • quiz-schema.yaml
  • review-schema.yaml
  • subject-schema.yaml

@ArtemHolikov ArtemHolikov added bug Something isn't working Backend labels Dec 12, 2024
@ArtemHolikov ArtemHolikov self-assigned this Dec 12, 2024
@ArtemHolikov ArtemHolikov linked an issue Dec 12, 2024 that may be closed by this pull request
(SP: ) Swagger docs: replace ref to $ref and components to definitions in docs files #1035
Open
12 tasks
ShadowOfTheSpace
ShadowOfTheSpace requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check user-schema.yaml file, please. User is defined as definition, not as component. Make changes in these files according to this information.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudchakk dudchakk Awaiting requested review from dudchakk

@markgol777 markgol777 Awaiting requested review from markgol777

@Made1ra Made1ra Awaiting requested review from Made1ra

@Mike-Popovych Mike-Popovych Awaiting requested review from Mike-Popovych

@luiqor luiqor Awaiting requested review from luiqor

@ShadowOfTheSpace ShadowOfTheSpace Awaiting requested review from ShadowOfTheSpace

Requested changes must be addressed to merge this pull request.

Assignees

@ArtemHolikov ArtemHolikov

Labels
Backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: ) Swagger docs: replace ref to $ref and components to definitions in docs files
2 participants
@ArtemHolikov @ShadowOfTheSpace