Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up H2 database for tests #28

Merged
merged 7 commits into from
Nov 6, 2020
Merged

Set up H2 database for tests #28

merged 7 commits into from
Nov 6, 2020

Conversation

AntonMishyn
Copy link
Contributor

Java enums are now stored as varchars in DB
H2 is set up to be used while testing

melnikovae87
melnikovae87 reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@melnikovae87 melnikovae87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use naming for implementation (not DB naming):
controllers (package)
UserController (class)

services (package)
UserSerive (interface)
UserServiceImpl (class)

entities (package)
UserEntity (class)

@AntonMishyn AntonMishyn merged commit d5f7319 into ita-social-projects:develop Nov 6, 2020
@AntonMishyn AntonMishyn deleted the feature/h2-test-setup branch November 9, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponruslan ponruslan ponruslan approved these changes

@melnikovae87 melnikovae87 melnikovae87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonMishyn @melnikovae87 @ponruslan