Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/set posts as Important/Unimportant with importance order #361

Merged
merged 6 commits into from
Jun 24, 2021
Merged

Feature/set posts as Important/Unimportant with importance order #361

merged 6 commits into from
Jun 24, 2021

Conversation

lizozavr
Copy link
Contributor

@lizozavr lizozavr commented Jun 23, 2021 •
edited
Loading

Issue link

#359 Set posts as Important/Unimportant with importance order

Code reviewers

Summary of issue

  • remove set-important endpoint
  • remove set-unimportant endpoint
  • implement new endpoint for setting posts important with order
  • implement tests for new code
  • implement new sql script for setting all posts unimportant

Summary of change

  • removed set-important endpoint
  • removed set-unimportant endpoint
  • implemented new endpoint for setting posts important with order
  • implemented tests for new code
  • implemented new sql script for setting all posts unimportant

lizozavr added 3 commits June 11, 2021 12:25
@lizozavr
importance order field
e1e274f
@lizozavr
Set order
4e3f37d
@lizozavr
Merge branch 'develop' into feature/order-for-important-posts
3e674c2 
# Conflicts:
#	src/main/java/com/softserveinc/dokazovi/service/PostService.java
#	src/test/java/com/softserveinc/dokazovi/controller/PostControllerTest.java
@lizozavr lizozavr added the backend Tasks for Java team label Jun 23, 2021
@lizozavr lizozavr added this to the Sprint 15 milestone Jun 23, 2021
@lizozavr lizozavr self-assigned this Jun 23, 2021
@lizozavr lizozavr requested a review from teaFunny June 23, 2021 07:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@lizozavr lizozavr linked an issue Jun 24, 2021 that may be closed by this pull request
Set post as Important/Unimportant with importance order #359
Closed
@lizozavr lizozavr merged commit d301233 into develop Jun 24, 2021
@lizozavr lizozavr deleted the feature/order-for-important-posts branch June 29, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teaFunny teaFunny teaFunny approved these changes

Assignees

@lizozavr lizozavr

Labels
backend Tasks for Java team
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.

Set post as Important/Unimportant with importance order
2 participants
@lizozavr @teaFunny