Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue_440_Main page sorting posts issue #443

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Issue_440_Main page sorting posts issue #443

merged 2 commits into from
Aug 16, 2021

Conversation

V-Kaidash
Copy link
Collaborator

@V-Kaidash V-Kaidash commented Aug 13, 2021 •
edited by TkachukI1
Loading

Issue link

#440 Main page sorting posts issue

Code reviewers

Summary of issue

  • Change set to list in the findLatestByPostTypesAndOrigins method's PostServiceImpl class
  • Adjuste SQL queries per each section by adding to ORDER BY clause ordering by post ID DESC

Summary of change

  • Change set to list in the findLatestByPostTypesAndOrigins method's PostServiceImpl class
  • Adjusted SQL queries per each section by adding to ORDER BY clause ordering by post ID DESC

@V-Kaidash
Change set to list in the findLatestByPostTypesAndOrigins method's Po…
92366e9 
…stServiceImpl class

Adjusted SQL queries per each section by adding to ORDER BY clause ordering by post ID DESC
@V-Kaidash V-Kaidash added backend Tasks for Java team SQL SQL issues labels Aug 13, 2021
@V-Kaidash V-Kaidash added this to the Sprint 19 milestone Aug 13, 2021
@V-Kaidash V-Kaidash self-assigned this Aug 13, 2021
@V-Kaidash V-Kaidash linked an issue Aug 13, 2021 that may be closed by this pull request
Main page sorting posts issue #440
Closed
@StanislavKucher StanislavKucher requested review from teaFunny and removed request for StanislavKucher August 13, 2021 16:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@V-Kaidash V-Kaidash merged commit c8e2b32 into develop Aug 16, 2021
@V-Kaidash V-Kaidash deleted the issue_440_Main_page_sorting_posts_issue branch August 16, 2021 11:22
KuzmaJava pushed a commit that referenced this pull request Sep 6, 2021
@V-Kaidash @KuzmaJava
Change set to list in the findLatestByPostTypesAndOrigins method's Po…
a97d1a1 
…stServiceImpl class (#443)

Adjusted SQL queries per each section by adding to ORDER BY clause ordering by post ID DESC
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teaFunny teaFunny teaFunny approved these changes

Assignees

@V-Kaidash V-Kaidash

Labels
backend Tasks for Java team SQL SQL issues
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging this pull request may close these issues.

Main page sorting posts issue
2 participants
@V-Kaidash @teaFunny