Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering posts of users by directions properly #445

Merged
merged 11 commits into from
Aug 16, 2021

Conversation

antoshaSid
Copy link
Contributor

GitHub Board

Issue link

#441 To filter posts of users by directions properly

Code reviewers

Summary of issue

  • add findAllDirectionsOfPostsByUserId() to the DirectionRepository
  • add findAllDirectionsOfPostsByUserId() to the DirectionService
  • create table with doctor_id, post_id, direction_id in migration
  • add endpoint USER_EXPERT_ALL_POST_DIRECTIONS to UserController

Summary of change

  • added all necessary methods
  • table is created
  • new endpoint is added

@antoshaSid antoshaSid added this to the Sprint 19 milestone Aug 16, 2021
@antoshaSid antoshaSid requested a review from teaFunny August 16, 2021 15:32
@antoshaSid antoshaSid self-assigned this Aug 16, 2021
@handicraftsman handicraftsman linked an issue Aug 16, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@handicraftsman handicraftsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already checked on my side. Although the SQL script was my idea, it should work.

@teaFunny, in case you find this overengineered or in any other way good to replace - treat this PR as a temporary change. We have to merge very soon, and we know that this works.

@antoshaSid antoshaSid merged commit ca57143 into develop Aug 16, 2021
@antoshaSid antoshaSid deleted the issue_441_expert_get_direction_while_posting branch August 16, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To filter posts of users by directions properly
3 participants