Fix post types filters and direction changing #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted this to a draft temporarily, to move the changed trigger into a repeatable migration so that we do not have to create a migration every time we change something. |
Izarx
approved these changes
Aug 19, 2021
…-direction-changing
|
Kudos, SonarCloud Quality Gate passed!
|
teaFunny
approved these changes
Aug 19, 2021
handicraftsman
deleted the
handicraftsman/fix-post-types-filters-and-direction-changing
branch
KuzmaJava
pushed a commit
that referenced
this pull request
Sep 6, 2021
* Fixed post types filters and direction changing * "Moved" existing triggers to a repeatable migration, so it is easier to edit them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop
Code reviewers
or
Summary of issue
Summary of change
PostTypeRepository#findAllPostTypesByUserIdmethod to make sure we only return types with published postsNotes
Yes, sadly thanks to how Flyway and similar tools work, we have to redefine the whole trigger function, and ignore its implementations in the previous migrations.