Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #629

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Bug fixes #629

merged 1 commit into from
Dec 22, 2023

Conversation

VadimasikKPI
Copy link
Contributor

add find user by author id into send activation token, add service class for verification token and write tests

develop

GitHub Board

Issue link

#11 Issue name

Story link

#11 Story

Code reviewers

  • @github_username

Summary of issue

  • Summary of issue
  • Summary of issue

Summary of change

  • Summary of change
  • Summary of change

…ass for verification token and write tests
public class VerificationTokenCleanupScheduler {
private final VerificationTokenService verificationTokenService;

@Scheduled(cron = "0 0 0 * * ?")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this, but won't block review due to it.

Just as a note - this won't work if you start scaling the app horizontally, you need an external scheduler or to enable clustering mode with a spring-supported embedded scheduler

Copy link
Contributor

@handicraftsman handicraftsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval granted.

@VadimasikKPI VadimasikKPI merged commit 88bd84e into develop Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants