Bug fix #169 materials are not sorted properly (#544)

* change reducer for ExpertMaterialsContainer.tsx * edit selector for materials at ExpertMaterialsContainer.tsx * edit selector for materials at ExpertMaterialsContainer.tsx
ita-social-projects · Aug 25, 2021 · 18821ff · 18821ff
1 parent a9e88e5
commit 18821ff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/models/helpers/selectors.ts b/src/models/helpers/selectors.ts
@@ -8,3 +8,7 @@ export const selectPostsByIds = (ids: number[]): IPost[] => {
 export const selectExpertsByIds = (ids: number[]): IExpert[] => {
   return ids.map((id) => store.getState().experts.data.experts[id]);
 };
+
+export const selectExpertPostsByIds = (ids: number[]): IPost[] => {
+  return ids.map((id) => store.getState().expertMaterials.data.posts[id]);
+};
diff --git a/src/old/modules/experts/components/ExpertMaterialsContainer.tsx b/src/old/modules/experts/components/ExpertMaterialsContainer.tsx
@@ -57,6 +57,7 @@ import {
   selectExpertsData,
 } from '../../../../models/expertMaterials';
 import { updatePostTypes, updateDir } from '../../utilities/utilityFunctions';
+import { selectExpertPostsByIds } from '../../../../models/helpers/selectors';
 
 export interface IExpertMaterialsContainerProps {
   expertId: number;
@@ -68,7 +69,6 @@ const ExpertMaterialsContainer: React.FC<IExpertMaterialsContainerProps> = ({
   expert,
 }) => {
   const {
-    posts,
     postIds,
     meta: { isLastPage, pageNumber, totalElements, totalPages },
   } = useSelector(selectExpertsData);
@@ -109,13 +109,7 @@ const ExpertMaterialsContainer: React.FC<IExpertMaterialsContainerProps> = ({
     };
   }, []);
 
-  const allMaterials = Object.values(posts);
-  const materials = [...allMaterials].filter((el) => {
-    if (postIds.find((elem) => elem === el.id)) {
-      return true;
-    }
-    return false;
-  });
+  const materials = selectExpertPostsByIds(postIds);
 
   const postTypes = useSelector(selectPostTypes);