Add button to cancel changes, add eventListener to handle closing tab… #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and asking user via popup to stay or close the tab.
skyboyer
reviewed
Sep 22, 2023
skyboyer
reviewed
Sep 23, 2023
| @@ -25,6 +25,9 @@ export const MAIN_THEME = createTheme({ | |||
| borderRadius: 0, | |||
| textTransform: 'none', | |||
| }, | |||
| label: { | |||
skyboyer
reviewed
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Pull Request *
Related links
Issue link
#633 Change editing author
Description *
Added button to cancel changes, made a popup which asks user to stay or quit page.
Summary of change
Cancel button just close the tab, so any changes will not be saved. As we cant make custom popup due to security politics of the browser, I have made a event listener that shows browser popup to ask user leave or not the page. Popup will be shown only if user interacts with a page. Also, made our "Підтвердити зміни" button adaptive, so both buttons have the same behaviour when viewport is changing.