Bug Fix 695 #830
Merged
Bug Fix 695 #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 22, 2023
skyboyer
reviewed
Nov 22, 2023
skyboyer
reviewed
Nov 23, 2023
… make new prop onSaveSuccessful in PersonalInfo component
skyboyer
reviewed
Nov 28, 2023
skyboyer
reviewed
Nov 29, 2023
skyboyer
approved these changes
Nov 29, 2023
src/old/navigation/types.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import React from 'react'; | |||
YuriyHryshchenko
added a commit
that referenced
this pull request
Jan 9, 2024
* Bugfix694 personal information (#829) * Select current user to display info about him on Personal Information page * Fix import order * Bug Fix 695 (#830) * Create, update author personal information. Remove 404 Error in page title. * Fix import order * Add try/catch, refactor code * Create useCheckAdmin reusable hook to check if current user is admin, make new prop onSaveSuccessful in PersonalInfo component * Create Wrapper for /create-author route, change onSaveSuccessfull prop * Edit prop to remove error * Remove import React * Issue634 create user account for author (#831) * Make buttons and form for creating user account * Remake form for new mock data * + Add ability to create user account for the author * * Fixed imports * * Change code according to the coments * * Fix import order * * Refactor conditional rendering for user account form buttons, remove comment lines, refactor styles for user account form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Pull Request *
Related links
#585 Personal Information Page Creation
#695 New author is not saved
#547 Page validation
Description *
Create functionality to update, create new author. Make first name and last name fields disabled for author in his personal information page as discussed this with team in daily, for creating and updating author by admin in "Адміністрування" after clicking "Підтвердити зміни" create redirect to expert page. If its own personal information page of author just dispatching action to get current user info to update info. Fixed Page Title with 404 error