fix(a11y): enhance navigation and fix ds nav mobile focus #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡ Lighthouse report for the home page 🏠
Other pages
|
Fupete
commented
Dec 19, 2023
Fupete
commented
Dec 19, 2023
Fupete
changed the title
astagi
approved these changes
Dec 20, 2023
Fupete
modified the milestones:
Design system: official release (2024 - Q1/Q2),
Design system: beta (2024 - Q1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1147
We will need to investigate further how to improve the
navscrollcomponent of Bootstrap Italia that we are currently repurposing for the sidebar of the design system. We will open an issue as soon as this is merged.This PR fix the urgent "focusable" part, now it is. However the keyboard "pattern" is still not perfect.