Skip to content

Commit

Permalink
test: check error msg test-writeint.js
Browse files Browse the repository at this point in the history
PR-URL: nodejs#10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
liirene1 authored and italoacasas committed Jan 23, 2017
1 parent 853fd7a commit 02fa0b3
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions test/parallel/test-writeint.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
require('../common');
const assert = require('assert');
const errorOutOfBounds = /^TypeError: "value" argument is out of bounds$/;

function test8(clazz) {
const buffer = new clazz(2);
Expand All @@ -17,10 +18,10 @@ function test8(clazz) {
/* Make sure we handle truncation correctly */
assert.throws(function() {
buffer.writeInt8(0xabc, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt8(0xabc, 0);
});
}, errorOutOfBounds);

/* Make sure we handle min/max correctly */
buffer.writeInt8(0x7f, 0);
Expand All @@ -30,10 +31,10 @@ function test8(clazz) {
assert.equal(0x80, buffer[1]);
assert.throws(function() {
buffer.writeInt8(0x7f + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt8(-0x80 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down Expand Up @@ -70,10 +71,10 @@ function test16(clazz) {
assert.equal(0x00, buffer[3]);
assert.throws(function() {
buffer.writeInt16BE(0x7fff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt16BE(-0x8000 - 1, 0);
});
}, errorOutOfBounds);

buffer.writeInt16LE(0x7fff, 0);
buffer.writeInt16LE(-0x8000, 2);
Expand All @@ -83,10 +84,10 @@ function test16(clazz) {
assert.equal(0x80, buffer[3]);
assert.throws(function() {
buffer.writeInt16LE(0x7fff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt16LE(-0x8000 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down Expand Up @@ -139,10 +140,10 @@ function test32(clazz) {
assert.equal(0x00, buffer[7]);
assert.throws(function() {
buffer.writeInt32BE(0x7fffffff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt32BE(-0x80000000 - 1, 0);
});
}, errorOutOfBounds);

buffer.writeInt32LE(0x7fffffff, 0);
buffer.writeInt32LE(-0x80000000, 4);
Expand All @@ -156,10 +157,10 @@ function test32(clazz) {
assert.equal(0x80, buffer[7]);
assert.throws(function() {
buffer.writeInt32LE(0x7fffffff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt32LE(-0x80000000 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down

0 comments on commit 02fa0b3

Please sign in to comment.