New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing default title coming from configuration of aggregations #79

Merged

cigolpl merged 3 commits into itemsapi:master from vanch3d:fix/title-aggregation

May 27, 2021

Contributor

vanch3d commented May 27, 2021

See #78

A simple fix to take default title from the configuration if it exists, using humanize otherwise.

fixed title defaulting from configuration of aggregations
changed the conjunctive search test
- to redefine the test aggregation object with different cases of title (unset, different from id. equal to id)
- to include asserts on the computed title of each bucket

vanch3d added 3 commits

May 27, 2021 11:45


          fixed title defaulting from configuration of aggregations

b610bf9


          changed test aggregation to cover different cases of title

f1e7dc4

added test for title of all three buckets


          bumped version

e543ed0

cigolpl merged commit b8f3d92 into itemsapi:master

Member

cigolpl commented May 27, 2021

Thanks Nicolas. I've published new version 2.1.2 into https://www.npmjs.com/package/itemsjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet