Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set progress when concatenating files. #16440

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Set progress when concatenating files. #16440

wants to merge 5 commits into from

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Oct 17, 2024

Fix #13610.

@dkocher dkocher added this to the 9.1 milestone Oct 17, 2024
@dkocher dkocher self-assigned this Oct 17, 2024
@dkocher dkocher requested a review from a team as a code owner October 17, 2024 18:34
@AliveDevil
Copy link
Contributor

Aufzeichnung.2024-10-22.144458.mp4

Need to assess whether this behavior is tolerable.

@dkocher
Copy link
Contributor Author

dkocher commented Oct 22, 2024

Need to assess whether this behavior is tolerable.

It would be preferrable if the progress bar would change to indeterminate spinning while finalizing.

@AliveDevil
Copy link
Contributor

So, while there is Progress in progress, disable Show/Open and do not rely on Transfer.completed?

@dkocher dkocher marked this pull request as draft October 22, 2024 13:20
AliveDevil
AliveDevil requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft: Add Indeterminate state to macOS interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliveDevil AliveDevil AliveDevil requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dkocher dkocher

Labels
None yet
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.

No progress when concatenating downloaded segments for large download after transfer is complete
2 participants
@dkocher @AliveDevil