Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base URL of GitLab for the /uploads URLs #1482

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 24, 2024

Could close #1478; not sure about compatibility with old GitLab versions, though.

@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 24, 2024
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review October 24, 2024 01:54
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Oct 24, 2024

@jancrichter, if you can test it with older GitLab versions and confirm it works as well, we can release this fix.

Note

It's a bit hacky, as it doesn't output full URLs unlike the assets.cml.dev uploads, but... 🤷🏼

@0x2b3bfa0 0x2b3bfa0 closed this Oct 24, 2024
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch October 24, 2024 01:58
@jancrichter
Copy link

jancrichter commented Oct 24, 2024

Hi, thanks for looking into it. Although, I am confused due to the PR being closed and the branch deleted, is it still an option to release this?

Myself, I cannot test on older Gitlab versions unfortunately, but the shortened link is what Gitlab has been using for native use uploads at least since Gitlab 15 from looking at the API.

@0x2b3bfa0 0x2b3bfa0 restored the 0x2b3bfa0-patch-1 branch October 24, 2024 12:53
@0x2b3bfa0 0x2b3bfa0 reopened this Oct 24, 2024
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) October 24, 2024 12:53
@0x2b3bfa0 0x2b3bfa0 requested a review from shcheklein October 24, 2024 12:54
@0x2b3bfa0 0x2b3bfa0 merged commit 4cac5a4 into main Oct 24, 2024
55 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch October 24, 2024 13:59
@0x2b3bfa0
Copy link
Member Author

@jancrichter, yes, I just closed it because I wasn't willing to merge this change without your confirmation, but if it runs on GitLab 15+, it feels like a good enhancement to me.

(Now it's merged and released, for the record)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CML comment create/update image links not working anymore in Gitlab
3 participants