-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVC log_plot error is confusing, if the template
attribute is set without a value.
#10482
Comments
Thanks @h-joshi for the detailed report. |
@h-joshi did you have some use case in mind to keep it empty? I wonder if just should raise an exception on the empty value and do not allow it in the first place. |
@shcheklein This should just raise an exception with a context relevant error message. I had missed adding the template and it took me a while to realise that the missing value was the root cause. |
Hey, willing to work on this, can anyone help with finding where exactly log_plot function or any related function is present? |
Fixed dvc issue #10482 at iterative/dvc#10482
Hi. It seems the code fix should go to dvclive repo. I have raised the PR with the fix. @shcheklein Would be able to review this? |
* Fix: Empty string as template in CustomPlot.init Fixed dvc issue #10482 at iterative/dvc#10482 * Fix None template in Custom Plot constructor * Update src/dvclive/plots/custom.py Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com> * Remove unnecesary tests in plots/test_custom.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
The fix for this issue is merged in dvclive iterative/dvclive#841 |
Thanks @anunayasri! |
Bug Report
Description
DVC
log_plot
error is confusing, if thetemplate
attribute is set without a value.Reproduce
log_plot
function to log a few metrics (Note: thetemplate
option is empty)Expected
Error should point out that a
template
needs to be specified if the attribute is specified.Environment information
Output of
dvc doctor
:Additional Information (if any):
The text was updated successfully, but these errors were encountered: