exp: abstract random name gen from repo #9806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9806 +/- ##
=======================================
Coverage 90.45% 90.45%
=======================================
Files 483 483
Lines 36858 36863 +5
Branches 5321 5321
=======================================
+ Hits 33339 33344 +5
Misses 2910 2910
Partials 609 609
☔ View full report in Codecov by Sentry. |
4 tasks
daavoo
approved these changes
Aug 6, 2023
skshetry
reviewed
Aug 7, 2023
Comment on lines
+86
to
+87
| def test_gen_random_name(): | ||
| assert re.match("[a-zA-Z]+-[a-zA-Z]+", gen_random_name()) |
There was a problem hiding this comment.
The test was not really necessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for iterative/dvclive#646 so that we can generate random names without a repo.