Skip to content

Commit

Permalink
Merge branch 'main' into exp-save-warning
Browse files Browse the repository at this point in the history
  • Loading branch information
Dave Berenbaum authored Jul 20, 2023
2 parents faa4bf0 + cfec6df commit d28f98f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ repos:
- id: sort-simple-yaml
- id: trailing-whitespace
- repo: https://github.com/psf/black
rev: 23.3.0
rev: 23.7.0
hooks:
- id: black
- repo: https://github.com/PyCQA/isort
Expand All @@ -34,7 +34,7 @@ repos:
additional_dependencies: ["tomli"]
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: 'v0.0.277'
rev: 'v0.0.278'
hooks:
- id: ruff
- repo: https://github.com/executablebooks/mdformat
Expand Down
24 changes: 17 additions & 7 deletions src/dvclive/lightning.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,23 @@
import inspect
from typing import Any, Dict, Optional

from lightning.fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from lightning.pytorch.loggers.logger import Logger, rank_zero_experiment
from lightning.pytorch.utilities import rank_zero_only
try:
from lightning.fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from lightning.pytorch.loggers.logger import Logger, rank_zero_experiment
from lightning.pytorch.utilities import rank_zero_only
except ImportError:
from lightning_fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from pytorch_lightning.loggers.logger import Logger, rank_zero_experiment
from pytorch_lightning.utilities import rank_zero_only

from torch import is_tensor

from dvclive import Live
Expand Down

0 comments on commit d28f98f

Please sign in to comment.