-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change save_dvc_exp warning to info #632
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 89.69% 89.47% -0.22%
==========================================
Files 43 44 +1
Lines 2988 2994 +6
Branches 250 250
==========================================
- Hits 2680 2679 -1
- Misses 269 276 +7
Partials 39 39
☔ View full report in Codecov by Sentry. |
logger.warning( | ||
"Ignoring `_save_dvc_exp` because `dvc exp run` is running" | ||
) | ||
logger.info("Ignoring `_save_dvc_exp` because `dvc exp run` is running") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ, is it how it is actual called - _save_dvc_exp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean for users? Or is it an internal name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. We should not be using the internal name here.
From https://github.com/iterative/dvclive/pull/631/files#r1269153204