Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_artifact: update warning inside exp #669

Merged
merged 3 commits into from
Aug 17, 2023
Merged

log_artifact: update warning inside exp #669

merged 3 commits into from
Aug 17, 2023

Conversation

dberenbaum
Copy link
Collaborator

Some fixes to the warnings when logging an artifact inside an experiment:

  1. Check if artifact is a subpath of a tracked output
  2. dvc exp remove -> dvc remove

@dberenbaum dberenbaum requested a review from daavoo August 16, 2023 15:51
daavoo
daavoo suggested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase the changes from #668

@daavoo daavoo added the A: dvc DVC integration label Aug 17, 2023
@daavoo daavoo merged commit 8ec70e4 into main Aug 17, 2023
10 checks passed
@daavoo daavoo deleted the log-artifact-warning branch August 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavoo daavoo daavoo approved these changes

Assignees

@dberenbaum dberenbaum

Labels
A: dvc DVC integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dberenbaum @daavoo