Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Actions on pull requests from public forks #115

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

daneah
Copy link
Member

@daneah daneah commented Feb 9, 2022

This change is a: (check at least one)

  • Bugfix
  • Feature addition
  • Code style update
  • Refactor
  • Release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the:

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite passing?
  • Code coverage maximal?
  • Changelog up to date?

What does this change address?

GitHub Actions triggered only by push don't trigger workflows from public forks. We're just noticing this now because contributors since switching to Actions have had write access to the repository and opened pull requests directly from branches.

How does this change work?

Also trigger Actions workflow on the pull_request event.

@daneah daneah added the 🐛 bug Something isn't working label Feb 9, 2022
.github/workflows/main.yml Outdated Show resolved Hide resolved
@daneah daneah mentioned this pull request Feb 10, 2022
11 tasks
@daneah daneah merged commit 8a6624c into dev Feb 10, 2022
@daneah daneah deleted the actions-on-pull-request branch February 10, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants