Merge pull request #502 from photomadic/fix/upload-job-retained

fix(upload): prevent memory leaks from retained jobs
itinance · Jun 9, 2018 · 8468d43 · 8468d43
2 parents 9b130ad + 7dbe488
commit 8468d43
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/RNFSManager.m b/RNFSManager.m
@@ -559,6 +559,7 @@ + (BOOL)requiresMainQueueSetup
   params.method = method;
 
   params.completeCallback = ^(NSString* body, NSURLResponse *resp) {
+    [self.uploaders removeObjectForKey:[jobId stringValue]];
 
     NSMutableDictionary* result = [[NSMutableDictionary alloc] initWithDictionary: @{@"jobId": jobId,
                                                                                      @"body": body}];
@@ -570,6 +571,7 @@ + (BOOL)requiresMainQueueSetup
   };
 
   params.errorCallback = ^(NSError* error) {
+    [self.uploaders removeObjectForKey:[jobId stringValue]];
     return [self reject:reject withError:error];
   };