Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import paths for react-native 0.40 #241

Closed
generalpiston opened this issue Jan 22, 2017 · 7 comments
Closed

Change import paths for react-native 0.40 #241

generalpiston opened this issue Jan 22, 2017 · 7 comments

Comments

@generalpiston
Copy link
Contributor

The import paths currently look like this:

#import <React/RCTLog.h>`

For react-native 0.39.x and newer it should look like this:

#import "RCTLog.h"
@alex-Z-
Copy link

alex-Z- commented Jan 23, 2017

Generally problem not only in repo, but also in React Native itself, as I can see in RCTBridge it still some links to React/*

@alfonsodev
Copy link

alfonsodev commented Jan 25, 2017

@AbeC, I would change the title of this issue to react-native 0.40 it's the version where this is really a problem.

@alex-Z-
Copy link

alex-Z- commented Jan 25, 2017

Yeah, very true, as for myself I found solution to add this task to package and run after installing dependencies ( I really tied to 0.4 ) probably will be useful for someone

"compat": "[ ! -L node_modules/react-native/React/React ] && cd node_modules/react-native/React && find ./ -type l | xargs rm && ln -s Base React && ln -s Base/* ./$1"

@generalpiston generalpiston changed the title Change import paths for react-native 0.39.x Change import paths for react-native 0.40 Jan 26, 2017
@abcd-ca
Copy link

abcd-ca commented Jan 26, 2017

These are the needed fixes, I tried adding them manually to my RN 0.40.0 project and it worked. l've requested the author create a pull request

@generalpiston
Copy link
Contributor Author

I updated the pull request with recommendations from https://medium.com/@thisismissem/how-to-upgrade-react-native-modules-in-a-backwards-compatible-manner-a5b5c48d590c#.vh7nbtd26. Could some one review/commit this?

#242

@jjhesk
Copy link

jjhesk commented Feb 17, 2017

do we need to do cocoapod for RNFS for RN 0.41.2

???

benvium pushed a commit that referenced this issue Feb 20, 2017
* change imports for react-native 0.39.x

* change imports for react-native 0.40.x

* order of imports matter

* Fix multiple import problem
@generalpiston
Copy link
Contributor Author

Thanks @benvium for merging.

@jjhesk not sure what you mean. It seems like the install instructions reference a local directory for cocoapods.

Closing this issue since it was addressed in #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants