(iOS only) Resumable downloads and better background downloads handling #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We've discussed about resumable downloads in my last pull request, I have not made any changes to this feature in this one.
Now about background downloads:
In my app I'm downloading large files, so bg-d/l is crucial.
I've encountered issues with bg-d/l using RNFS and found out it's because the download tasks's completion handler is not being call, thus iOS brutally terminates the app.
So I've added a new method called
completeHandlerIOS(jobId)
that will call that job's completion handler.Now bg-d/l are safe to use and you can easily do some stuff after the download is done and then call
completeHandlerIOS()
.readme was updated with a tutorial on how to set this up in the AppDelegate.m file.
I've also removed the bit in the readme about needing to activate 'background fetch' since it's not true,
background fetch
is for periodically connecting to the internet to fetch some data, it's not needed for downloads.