fix: Xcode 12 compatibility #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itinance Do you think this can be merged to master? |
|
Hi there, do we think this could be merged in soon? The scope seems small enough, and doing so would unblock our project from using the new Xcode build system. |
|
@itinance that's not breaking |
|
@itinance Friendly ping for merging this small, but very needed PR 😸 |
|
@itinance |
|
Thanks guys, it's now merged by #1031 (haven't seen this one earlier here, sorry) |
|
This is so great that this was merged in! I'm unfamiliar with the release process for this library. Do we have a sense of when the next version would be released, and if this change would be included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Xcode 12 fails to build without a module to depend on
React-Coredirectly hence this change is necessary for all native modules on iOS. This change requires React Native 0.60.2 or newer. For more details please check: facebook/react-native#29633 (comment)