Add basic support for Android content URIs in stat #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a basic implementation of stat for content URIs that returns what it can return: the file length.
viveking
suggested changes
Jan 3, 2021
|
Thanks for the feedback! It doesn't look as straightforward as the non-content schemes, but I will have a look at it. |
|
It's been a month and I haven't been able to take a look at it. I'm not sure I will be able to in the near future. So feel free to close this PR if you want to keep the project clean. |
|
Alright. I'm going to close this as you suggested. Pls feel free everybody to bring this to life later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic implementation of stat for content URIs that returns what
it can return: the file length.
This also raises the Android SDK API requirements of this method from 1 to 3, which is... fine I guess ?
If you see anything else I can return for a content URI I will be glad to add it.