-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset validation for sync push command #241
base: master
Are you sure you want to change the base?
Conversation
@@ -52,9 +52,20 @@ struct TestFlightProgramDifference { | |||
} | |||
} | |||
|
|||
enum Error: LocalizedError, Equatable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an argument to be made around not adding equatable conformance in the implementation if you only use it for testing. Not sure how I feel about it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an argument to be made around not adding equatable conformance in the implementation if you only use it for testing. Not sure how I feel about it though
Any ideas for removing the Equatable in this case? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted to you could replace the instances in testing with something like:
XCTAssertThrowsError(try TestFlightProgramDifference(local: local, remote: remote)) { error in
guard case TestFlightProgramDifference.Error.duplicateTesters(let email) = error else {
return XCTFail()
}
XCTAssertEqual(email, "foo@gmail.com")
}
Adding validation and error handling logic for sync push command
📝 Summary of Changes
Changes proposed in this pull request:
duplicateTesters
error for handling duplicate testers with the same email addresses.noValidApp
error when the user hasn't runsync pull
beforesync push
🧐🗒 Reviewer Notes
💁 Example
🔨 How To Test