This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Conflicting Block Entry Resolution #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tries first perform cascaded deletion of block entry, then create new entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
I noticed, sometimes when re-organisations happen, already put block entries need to be updated with latest one found from full node ( via RPC/ WS ), which involves first deleting all packed transactions/ events in that block ( along with self ) & then putting new block entry in database again.
I decided to simplify the flow by introducing cascaded deletion, which requires only calling single function for deleting block entry ( identified using block number ), deletes all transactions/ events previously included in block. Finally call another function to create new block entry, then put transactions/ events.