Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish docker images for Pull Requests #1868

Closed
wants to merge 1 commit into from
Closed

Publish docker images for Pull Requests #1868

wants to merge 1 commit into from

Conversation

LennyPenny
Copy link
Contributor

This should make the testing of PRs easier for people that run docker setups!

@hackerncoder hackerncoder added the need-code-review A crystal developper need to check if the code is correct. label Mar 5, 2021
@LennyPenny
Copy link
Contributor Author

(the step fails because I obviously don't have access to the invidious quay.io repo)

@LennyPenny LennyPenny mentioned this pull request Mar 5, 2021
Closed
@Perflyst
Copy link
Contributor

Perflyst commented Mar 5, 2021

(the step fails because I obviously don't have access to the invidious quay.io repo)

It will fail for anyone who does not have access to this repository.
We tried this in the past, e35345f, this does not work. Did you get this working somewhere else with some custom settings @LennyPenny?

@LennyPenny
Copy link
Contributor Author

ah yea nvm the logic is flawed

it would be a very bad idea to let random people upload to the invidious quay account

@LennyPenny LennyPenny closed this Mar 5, 2021
@LennyPenny
Copy link
Contributor Author

LennyPenny commented Mar 5, 2021 •
edited
Loading

the only way this could work is for people that can create branches on this repo to create pull requests from

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Perflyst Perflyst

Labels
need-code-review A crystal developper need to check if the code is correct.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LennyPenny @Perflyst @hackerncoder