Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action server example #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add action server example #1

wants to merge 4 commits into from

Conversation

ivanpauno
Copy link
Owner

Example action server code.

I have added this here until we add the action server implementation from osrf/ros2_java#65 to ros2-java/ros2_java.

How to test:

# terminal 1
ros2 run rcljava_examples fibonacci_action_server
# terminal 2
ros2 action send_goal /fibonacci example_interfaces/action/Fibonacci "{order: 10}"

@ivanpauno
Add action server example
29b9483 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label May 4, 2021
@ivanpauno ivanpauno self-assigned this May 4, 2021
@ivanpauno
Copy link
Owner Author

@jacobperron FYI

@ivanpauno ivanpauno mentioned this pull request May 4, 2021
Merged
6 tasks
@ivanpauno
fix
20fb6ab 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Remove gradle.properties, add to gitignore
3e4da3a 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
jacobperron approved these changes May 6, 2021
View reviewed changes
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we should consider forking ros2_java_examples into the osrf org until we can get it upstreamed. What do you think?

@ivanpauno
Copy link
Owner Author

Maybe we should consider forking ros2_java_examples into the osrf org until we can get it upstreamed. What do you think?

Sounds good to me!
Could you create one? I think I don't have permissions to do that in osrf org.

@jacobperron
Copy link

Done https://github.com/osrf/ros2_java_examples

@ivanpauno
Remove gradle.properties
b340fff 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @jacobperron