version PEN1.6 : final corrections #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msdemlei
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
NB I have not cross-checked the changes with https://wiki.ivoa.net/twiki/bin/view/IVOA/UCDList_1-6_RFM. Should I have?
Other than the two minor points, I'd say let's go.
| @@ -214,4 +215,7 @@ em.UV.FUV em.UV.100-200nm | |||
| meta.ref.ivorn meta.ref.ivoid | |||
| pos.bodyrc.long pos.bodyrc.lon | |||
| pos.eop.nutation pos.nutation | |||
| #Changes from 1.5 to 1.6 | |||
| pos.lambert pos.projection | |||
There was a problem hiding this comment.
I think there's a line feed missing here
ucd-list.txt
Outdated
| @@ -133,6 +133,9 @@ P | meta.code.mime | MIME type | |||
| P | meta.code.multip | Multiplicity or binarity flag | |||
| P | meta.code.qual | Quality, precision, reliability flag or code | |||
| P | meta.code.status | Status code (e.g.: status of a proposal/observation) | |||
| Q | meta.coverage | A coverage (spatial, temporal, spectral, etc) | |||
| with any combination of physical axis (such as moc, tmoc, stmoc, s_region). | |||
There was a problem hiding this comment.
I think s_region should be left out here; it's not a datatype. You could write "as in obscore's s_region", but I don't think that would help. Also, it'd be "axes" here.
update workflow for preview
Update in WF ?? / not clear
BaptisteCecconi
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small updates for tex + ucd-list files + Makefile