ask for merge of last corrections for loumir/pen1_6 into ivoa-std/WD-1.6 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Baptiste Cecconi <baptiste.cecconi@obspm.fr>
trial to fix issue in generating PDF : upgraded version for upload/artifact. use v4.
…actionUploadArtifact-version-4 Update build.yml
update workflow for preview
Update in WF ?? / not clear
BaptisteCecconi
approved these changes
Oct 18, 2024
msdemlei
reviewed
Oct 18, 2024
| @@ -1,4 +1,4 @@ | |||
|  | |||
|  | |||
There was a problem hiding this comment.
I'm a CI skeptic and am not sure what this does, but if this is "WD" rather "PEN", there's something wrong with the underlying CI code, and that would need to be fixed.
| P & \ucd{stat.correlation}& Correlation between two parameters\\ | ||
| P & \ucd{stat.covariance}& Covariance between two parameters\\ | ||
| P & \ucd{stat.error}& Statistical error\\ | ||
| P & \ucd{stat.error.sys}& Systematic error\\ | ||
| Q & \ucd{stat.falsePositive}& Rate of false alarm in detection problems\\ | ||
| Q & \ucd{stat.falseNegative}& Rate of missed or false negative detection\\ |
There was a problem hiding this comment.
Is there a rationale for making them Q? Where would these be in a secondary position?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.