Github Actions CI and modern config #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests are failing due to testInterval(), but are being run correctly. On Python 3.12, `nose` is failing. We should upgrade to `nose2`, or more likely, switch from unittest + nose to pytest. - Move tox config to setup.cfg for now - TODO move to pyproject.toml instead of setup.cfg - TODO remove .travis.yml
Remove setup.cfg and setup.py in favor of pyproject.toml Nose and Tox are next to go. Nose seems to be failing on Python 3.10, no need for it any more as pytest should cover its features. Likely no need for tox either as we are using the matrix strategy in Github Actions, though it could be useful for local dev
|
This looks great. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a CI workflow on Github Actions for
python-edtf. The workflow uses a matrix strategy to test Python versions from3.8to3.12.v5ofpython-edtfdrops support for Python <3.8. This PR also drops thetravis.ciconfig.This PR drops
noseandtoxin favor forpytest.noseis beyond EOL and was failing with newer versions of Python;nose2does not seem to have many benefits overpytestas a testing framework. Whiletoxhas some benefits for local testing of multiple versions, it is unnecessary in CI given the Github Actions matrix strategy. I migrated thetoxconfig topyproject.tomlif developers still want to usetoxlocally, but have removed it from the test dependencies.This PR consolidates config in
pyproject.tomlrather than splitting acrosssetup.py,setup.cfg, andtox.ini.