Reformat tests to use Pytest style; fix infinite comparison for OneOfASet #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use parameterization in pytest to simplify many test cases by wrapping the input and expected values in tuples - No need for unittest or class wrappers - There is a legitimately failing test in parser/tests.py - code change needed in parser_classes to handle this I think - natlang/tests.py will need to be updated to match the new spec, as will the whole text_to_edtf() function
The max and min functions now use a generator expression to filter out infinite values unless they are directly relevant to the calculation; if inf or -inf are found, they are returned instead of doing a comparison.
Use v5, which uses node v20 rather than deprecated v16
|
Wow, this makes things much clearer. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytestformat tests have more functionality and are a bit cleaner.The failing test was due to
OneOfASet._estrict_date()potentially returninginfor-inf. This fixes the logic there to returninfor-infif aninfor-infare in the set with aLATESTorEARLIESTlean, respectively. It returns before making the comparison that was previously failing (TypeError: '>' not supported between instances of 'float' and 'time.struct_time').