Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable to stop one or more labs #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jedrekdomanski
Copy link
Contributor

@jedrekdomanski jedrekdomanski commented Aug 4, 2024

Make

labctl playground stop playID

to accept a list of playground IDs. Pretty much make it work like docker stop

docker stop cont1 cont2 cont3

so it looks like

labctl playground stop playID1 playID2 playID3

@jedrekdomanski
Copy link
Contributor Author

@iximiuz The code does what I expect it to do (it iterates over the list of passed in playground IDs to stop command), however the spinner somewhat stands on my way now and I can't get my head around how it works. It will just process the first playground ID and "eat" all other playgrounds so they won't get stopped. Can you take a look at it? 👁️

@jedrekdomanski jedrekdomanski changed the title [WIP] Attempt to stop one or more labs [WIP] Enable to stop one or more labs Aug 4, 2024
@jedrekdomanski
Copy link
Contributor Author

jedrekdomanski commented Aug 4, 2024

Or it may as well be related to GET'ing the playground ID which checks the status before it continues processing. I noticed that GET'ing a list of playgrounds in CLI is somewhat "laggy". What I mean by that is that when I refresh the dashboard page I see the playgrounds are gone however when I GET the list of playgrounds in CLI it still shows some active playgrounds. Not sure which is the source of truth here :)

@jedrekdomanski jedrekdomanski force-pushed the enable-to-stop-one-or-more-playgrounds branch from f88749f to 3f14e87 Compare August 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant