T28: Contributes to documentation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielgranadoscampos
commented
Jan 14, 2022
danielgranadoscampos
commented
- Adds english translated vignettes closing Decide how to work with vignettes when the package is available in 2 languages #15
- Adds new sections to vignettes about authentication workflow and sections about the new functions to contribute to Update documentation in vignettes #28
- Closes Mistake in credentials vignette #41
- Adds translated versions of functions add_upstream() and set_git_timeout()
- Adds keyring structure to add_upstream()
- Adds to new images about the authentication gadget
- Adds new section to readme contributing to Update readme #85
andreavargasmon
requested changes
Jan 14, 2022
ronnyhdez
reviewed
Jan 17, 2022
R/git.R
Outdated
| #' este momento | ||
| #' @return | ||
| #' @export | ||
| incluye_upstream <- function(instancia = "guardada"){ |
There was a problem hiding this comment.
Faltan espacios entre ")" y "{"
R/git.R
Outdated
|
|
||
|
|
||
| #' @title Extienda el tiempo de sus credenciales de git | ||
| #' @description Esta es una traducida que llama a set_git_timeout(). |
There was a problem hiding this comment.
Supongo que aquí va "esta es una función traducida"
| #' esto está escrito para trabajar en servidores remotos donde no queremos | ||
| #' almacenar nuestras credenciales de git (otros pueden tener acceso o | ||
| #' hacerse pasar por nosotros). En una máquina confiable, la configuración más | ||
| #' común sería (en una máquina Linux) <git credential.helper store>. Sin |
There was a problem hiding this comment.
Creo que esto no es únicamente una máquina Linux. Porque se puede hacer desde la terminal de RStudio, pero no estoy seguro cómo funcionaría en macOS o en windows
There was a problem hiding this comment.
Nuevo tiquete para esta duda #90
R/sync_branch.R
Outdated
| #' por medio de git rebase | ||
| #' | ||
| #' @export | ||
| actualizar_rama <- function(){ |
There was a problem hiding this comment.
Esto supongo que es una función en construcción o bien hay que validar si no se quedó código fuera del commit
There was a problem hiding this comment.
Esta es función es una traducción al español, por lo que en el cuerpo solo llama a sync_branch()
andreavargasmon
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.