fix: Don't mutate original enabled_environments

Ensure enabled_environments contains test environment without mutating original list. See: getsentry#2269 (comment)
ixti · Mar 22, 2024 · a573841 · a573841
1 parent ffffce9
commit a573841
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Bug Fixes
 
 - Don't instantiate connection in `ActiveRecordSubscriber` ([#2278](https://github.com/getsentry/sentry-ruby/pull/2278))
+- Don't mutate original `enabled_environments` when using test helpers ([#2275](https://github.com/getsentry/sentry-ruby/pull/2275))
 
 ## 5.17.1
 

diff --git a/sentry-ruby/lib/sentry/test_helper.rb b/sentry-ruby/lib/sentry/test_helper.rb
@@ -20,7 +20,7 @@ def setup_sentry_test(&block)
       # set transport to DummyTransport, so we can easily intercept the captured events
       dummy_config.transport.transport_class = Sentry::DummyTransport
       # make sure SDK allows sending under the current environment
-      dummy_config.enabled_environments << dummy_config.environment unless dummy_config.enabled_environments.include?(dummy_config.environment)
+      dummy_config.enabled_environments |= [dummy_config.environment] unless dummy_config.enabled_environments.include?(dummy_config.environment)
       # disble async event sending
       dummy_config.background_worker_threads = 0