-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespaces #780
base: main
Are you sure you want to change the base?
Namespaces #780
Conversation
@MImmesberger The nested function dictionary is currently structured like this: Which levels of nesting should be removed? Based on our previous discussion, it's probably the first two, i.e. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
- Coverage 89.69% 89.31% -0.39%
==========================================
Files 53 53
Lines 3796 3810 +14
==========================================
- Hits 3405 3403 -2
- Misses 391 407 +16 ☔ View full report in Codecov by Sentry. |
I think that, for example, |
Looking at that, I'd almost think that What do you think, @MImmesberger ? In any case, not super-important for the moment, the good thing is that it will be fairly easy to do bulk-renamings / removals (granted it seems more difficult to insert a level back than to remove it, so I'd be fine with an approach applying a bit more caution at the moment). |
I agree, there should be no overlap between the elements one level below the Regarding the naming of |
Agreed, let's use I'm all for good docstrings, but any tax deduction should go into the tax component it is deducted from, right? |
Yes definitely. Was just thinking about making it as obvious as possible. In our case "Kinderbonus" is a transfer. |
More in line with the naming of modules might be |
Good catch! Those are scheduled to be changed to
But that was not impossible to know, ofc! |
Should the renamings/removals be done programmatically in the new function or by changing the directory structure under Edit: For now, remove |
Just came across #533 -- might that be fixed in passing here? |
What problem do you want to solve?
Reference the issue or discussion, if there is any. Provide a description and/or bullet
points to describe the changes in this PR.
Todo
Closes #XXXX
in the first PR comment to auto-close the relevant issue oncethe PR is accepted. This is not applicable if there is no corresponding issue.