Skip to content

Commit

Permalink
Implement feature #291 Switch back navigation bar material theme on t…
Browse files Browse the repository at this point in the history
…rue black.
  • Loading branch information
j-fbriere committed Apr 30, 2024
1 parent 5656c14 commit c735d04
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions fastlane/metadata/android/en-US/changelogs/45.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Implement PR #297 Add true black tweet cards when system theme is dark (thanks @TheHJC).
* Implement feature #296 Show Community Note.
* Fix issue #258 Rearranging subscriptions duplicates subscription list.
* Implement feature #291 Switch back navigation bar material theme on true black.
1 change: 1 addition & 0 deletions fastlane/metadata/android/en-US/changelogs/default.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Implement PR #297 Add true black tweet cards when system theme is dark (thanks @TheHJC).
* Implement feature #296 Show Community Note.
* Fix issue #258 Rearranging subscriptions duplicates subscription list.
* Implement feature #291 Switch back navigation bar material theme on true black.
2 changes: 2 additions & 0 deletions lib/home/home_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ class ScaffoldWithBottomNavigationState extends State<ScaffoldWithBottomNavigati
),
bottomNavigationBar: NavigationBar(
selectedIndex: _selectedIndex,
backgroundColor: Theme.of(context).brightness == Brightness.dark && PrefService.of(context).get(optionThemeTrueBlack) ? Colors.black : null,
indicatorColor: Theme.of(context).brightness == Brightness.dark && PrefService.of(context).get(optionThemeTrueBlack) ? Colors.black : null,
labelBehavior: NavigationDestinationLabelBehavior.alwaysShow,
destinations: [
..._pages.map((e) => NavigationDestination(icon: Icon(e.icon, size: 22), label: e.titleBuilder(context)))
Expand Down

2 comments on commit c735d04

@itsharley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the issue

@j-fbriere
Copy link
Owner Author

@j-fbriere j-fbriere commented on c735d04 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?
I don't understand. It does fix the issue for me.
Here is how it looks on my device:
Screenshot_20240503_111708_Squawker
There is no more background color on the selected icon. So I don't see the problem.
Please elaborate.

Please sign in to comment.