Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bring back stack_upwards #152

Closed
j-hui opened this issue Nov 11, 2023 · 3 comments · Fixed by #160
Closed

feat: bring back stack_upwards #152

j-hui opened this issue Nov 11, 2023 · 3 comments · Fixed by #160
Assignees
@0xAdk
Labels
enhancement New feature or request

Comments

@j-hui
Copy link
Owner

j-hui commented Nov 11, 2023

Invert the order in which we stack notification items (and the group title); omitted in #143
@j-hui j-hui added the enhancement New feature or request label Nov 11, 2023
@j-hui
Copy link
Owner Author

j-hui commented Nov 12, 2023

@0xAdk responding to #158 (comment) here (since I think this is the feature you're referring to?)

I think flipping the order of the lines needs be done in notification/view; otherwise, multi-line messages will get messed up.

If you'd like to take a crack at it, I'm happy to assign this issue to you (:

@0xAdk
Copy link
Contributor

0xAdk commented Nov 12, 2023

I'll try

@j-hui
Copy link
Owner Author

j-hui commented Nov 12, 2023

Tip: use require("fidget.logger").warn( etc ) for printing and tail the log in another window for debugging; at least for me this has been a lot less cumbersome than directly print()ing to Neovim's :messages buffer

@0xAdk 0xAdk mentioned this issue Nov 12, 2023
Merged
j-hui added a commit that referenced this issue Nov 13, 2023
@0xAdk @j-hui
feat!: add stack upwards option (#160)
03d2192 
* feat: add stack upwards option

* Refactor view.lua a little to separate out helpers

* Documentation

Closes #152 

---------

Co-authored-by: 0xadk <0xadk@users.noreply.github.com>
Co-authored-by: j-hui <j-hui@cs.columbia.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xAdk 0xAdk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: add stack upwards option 0xAdk/fidget.nvim
2 participants
@j-hui @0xAdk