-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integration): xcodebuild.nvim integration (#207) #212
Conversation
Oops, sorry I didn't see this. I already pushed d1b2a71 ; can you rebase on top of that? The comment you left in there is very helpful too. |
Rebased :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great overall, thanks so much!
Just a couple of nits and questions, but honestly nothing I would consider blockers for the PR.
The main thing is I'd prefer either an explanation of why the nvim-tree offset was changed, or for that change to be reverted in both nvim-tree and xcodebuild.
Oh, one more thing: can you drop a change in the README advertising this integration option? Here https://github.com/j-hui/fidget.nvim/blob/main/README.md?plain=1#L241-L245 |
Works quite well :) demo.mov |
Looks awesome, I'm gonna merge it! Thanks so much for the contribution! |
🍻 thank you for the great plugin! |
Resolves #207
Also fixes off-by-one error in nvim-tree x_offset adjustment