Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to native Guid type #47

Closed
delfuria opened this issue Jul 20, 2017 · 2 comments
Closed

Add support to native Guid type #47

delfuria opened this issue Jul 20, 2017 · 2 comments

Comments

@delfuria
Copy link

Hi, i have tried to fork your project for make a PR but since you have used the new 2017 VS format i'm not able to do that.
So i ask you, if possible to add support to guid type simply adding a single line of code to the file

ValueArgument.cs

On method

protected virtual TValue DefaultConvert(string stringValue)

you have a lot of "if" statement for manage the native type and if you add this line of code

           if (valueType == typeof(Guid)) return (TValue)(object)Guid.Parse(stringValue);

just below the last if all works fine.
Thanks in advance

j-maly added a commit that referenced this issue Jul 20, 2017
@j-maly
Copy link
Owner

j-maly commented Jul 20, 2017

Added in 3.0.13. Guid.Parse is not available in all versions of .NET, but I've added some ifdefs around that..

@j-maly j-maly closed this as completed Jul 20, 2017
@delfuria
Copy link
Author

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants