-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of hook script after we release cordova-android update #760
Comments
I wonder if this is why I cannot compile on PGB with CLI 8.1.1 (Android 7.1.2)? I get the error: and
|
UPDATE: I tried it with 7.2.8 and got by the above error but then ran into this (using NPM as source): |
Looks like this has been done, thanks @j3k0! |
Thanks to you Chris! :)
|
Can you please state the version of the plugin that this has been fixed on? Also does it address #803 or not. That thread sort of sounded like it could not be fixed until/if PGB updated to a more recent build. |
I added some instructions about this in the README.
https://github.com/j3k0/cordova-plugin-purchase/blob/master/README.md#install-the-plugin-phonegap
…On Thu, Jun 6, 2019, 23:07 Chris C ***@***.***> wrote:
Can you please state the version of the plugin that this has been fixed on?
Also does it address #803
<#803> or not. That
thread sort of sounded like it could not be fixed until/if PGB updated to a
more recent build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#760?email_source=notifications&email_token=AABO3CI74UN4V4JL22PT4GDPZFU6LA5CNFSM4GD4NW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXEAHBI#issuecomment-499647365>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABO3CIFLBVGZBBCJCUXTELPZFU6LANCNFSM4GD4NW4Q>
.
|
:-) |
As I said in #759 you should not need a hook script once we release the next cordova-android update. I already tested that it is possible to install, build, and uninstall
https://github.com/j3k0/cordova-plugin-purchase#v7.1.0
(version before you added extra aidl entry and hook script) with the proposed cordova-android update.Plugin hook scripts can be sensitive to plugin structure and do not work with PhoneGap Build.
The text was updated successfully, but these errors were encountered: