Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing param display and added an alert when running module main steps #271

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

catmandx
Copy link
Contributor

Before, when passing module parameters that differs from the default one, the app wrongly displays that the default value is being used: for example param "enableDnsBruteFocing" in "fast" routine

❯ osmedeus.exe -f fast -t example.com -p "enableDnsBruteFocing=true" 
...
[2024-02-15T17:19:19]  INFO 🔘 Toggleable and Skippable Parameters that being use: enablePermutation=false, enableDnsBruteFocing=false,
...

Change the order when parsing parameters so that user-supplied parameters values overwrites default values. After:

❯ osmedeus.exe -f fast -t example.com -p "enableDnsBruteFocing=true" 
...
[2024-02-15T17:19:19]  INFO 🔘 Toggleable and Skippable Parameters that being use: enablePermutation=false, enableDnsBruteFocing=true,
...

When the main module steps takes too long, it could be confusing when users only see "Running prepare scripts for module xxx" for a very long time, so I've added a message when the main steps run.


Fixed 2 typos.

@j3ssie j3ssie merged commit cd3a133 into j3ssie:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants