Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle.yml #592

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Update gradle.yml #592

merged 4 commits into from
Apr 2, 2024

Conversation

tonihele
Copy link
Contributor

Not to repeat allowing PRs break the build... CI build on PRs

Not to repeat allowing PRs break the build... CI build on PRs
@tonihele
Copy link
Contributor Author

This is a really simple change. I just divided the existing job to two phases. The actual NBM deployment is skipped on PRs. But should be still executed on PUSHes to master as it used to (not tested). PR just builds the SDK. No fancy workflows or matrices where used.

@MeFisto94
Copy link
Member

Historically we had a separate build that was basically running via travis, that's why GHA only did the deployment build. I think there may have been slight nuanced differences.

I just wanted to check it but apparently we even removed the travis file already

@tonihele
Copy link
Contributor Author

Historically we had a separate build that was basically running via travis, that's why GHA only did the deployment build. I think there may have been slight nuanced differences.

I just wanted to check it but apparently we even removed the travis file already

Here:
https://github.com/jMonkeyEngine/sdk/blob/56ce13e34e81c7cdd1b6f224d69a744e5377aa30/.travis.yml

@tonihele tonihele merged commit 8a5aa12 into master Apr 2, 2024
3 checks passed
@tonihele tonihele deleted the feature/build-PR-workflow branch April 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants