Strip colors from messages and metadata #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to strip out the color escape codes (i.e.
[33m
) from the logs sent to Logstash. It looks like Winston exposes a string transform we can use here to do this: https://github.com/flatiron/winston/blob/ea8bb5b7b2c58274dc128e1942846c8f1c9c19ae/lib/winston/common.js#L129.Would love to iterate on this if there is a better way; this is my first pass.